Repository navigation
fix(vmm): give a simulated TDX guest the vm_config of a TDX guest - #1590
Merged
Merged
Conversation
A guest with simulated_tee = dstack-tdx runs without TDX, so its vm_config resolved to the legacy variant and carried no tdx_measurement. Its simulator then reports placeholder measurements, and a KMS, which verifies the OS image of every key request, refuses it: the legacy path recomputes the MRs from the image. Resolve the TDX attestation variant and attach the measurement document for a simulated TDX guest as for a TDX one, unless it has a swtpm: the lite ACPI measurement does not cover one, so the simulator could not derive its measurements. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
fix/vmm-simulated-tdx-vm-config
branch
from
November 15, 2026 20:44
18a6ae9 to
a8c4e13
Compare
kvinwang
added a commit
that referenced
this pull request
Nov 16, 2026
The harness pointed DSTACK_CCEL_FILE at the repository's sample CCEL. A simulated TDX guest now takes the lite path (#1590), where the KMS checks the ACPI table digests of the event log; the simulator patches them for the guest's vm_config, the sample does not. Import the event log and RTMR paths the simulator publishes in the systemd manager environment, as the guest's own services get them. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A guest deployed with
simulated_tee = dstack-tdxruns withno_tee, somake_vm_configresolved it to the legacy TDX variant and attached notdx_measurement. Its TEE simulator then reports placeholder measurements (MRTD0x11…), and a KMS, which verifies the OS image of every key request, refuses it: the legacy path recomputes the MRs from the image.Resolve the TDX attestation variant and attach the measurement document for a simulated TDX guest as for a TDX one, unless it has a swtpm: the lite ACPI measurement does not cover one (
swtpm measurement is not supported), so such a guest keeps the placeholder measurements. The simulator already derives the lite measurements from the document, the way the verifier recomputes them.Found by #841 on tdxlab:
tc-gos-setup-009,tc-gos-attestatio-003,tc-gos-boot-and-i-003and-004failed withMRTD mismatchwhen the guest requested its keys from the case KMS.Testing
simulated_tee, it gets no document.cargo test -p dstack-vmmpasses; clippy with the CI flags andcargo fmt --checkpass.tc-vmm-vmm-007,tc-vmm-vm-lifecyc-002,tc-gos-setup-004, ...) still boot. Full test: add colocated core component acceptance suite #841 runpr841-validate-1115-full-5c5a85f86: 370 PASS, 7 BLOCKED (no CC GPU), 2 failures that passed rerun alone.